Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added componentsAtPoint() iterable #1518

Merged
merged 33 commits into from
Apr 25, 2022
Merged

feat: Added componentsAtPoint() iterable #1518

merged 33 commits into from
Apr 25, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Apr 7, 2022 •
edited
Loading

Description

  • Added method Component.componentsAtPoint() which returns an iterable of descendant components intersecting with the given point, together with the points of intersection. This method can be used, for example, for event handling.
  • Method Component.containsLocalPoint(), similar to Component.containsPoint but takes a point in local coordinate space.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

WIP for #1326
WIP for #1511

spydon
spydon approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some docs missing, then I think that this is ready to be merged.

spydon
spydon approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written docs, just one word missing

doc/flame/components.md Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) April 25, 2022 15:53
auto-merge was automatically disabled April 25, 2022 16:58

Head branch was pushed to by a user without write access

@spydon spydon merged commit b99e351 into flame-engine:main Apr 25, 2022
@st-pasha st-pasha deleted the ps/components-at-point branch April 25, 2022 18:11
@st-pasha st-pasha mentioned this pull request Apr 30, 2022
Closed
@st-pasha st-pasha mentioned this pull request May 10, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st-pasha @spydon @wolfenrain